ci: use npm ci with ignored scripts#488
Open
noritaka1166 wants to merge 2 commits into
Open
Conversation
wdavidw
requested changes
Jun 13, 2026
| node-version: ${{ matrix.node-version }} | ||
| - run: npm install | ||
| - run: npm ci --ignore-scripts | ||
| - run: npm rebuild duckdb |
Member
There was a problem hiding this comment.
I don't see what this is trying to fix considering the we don't have error in the CI. Also, this belongs to the issue-esm json package file and should be isolated inside a separated commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This updates the publish workflow to make dependency installation more deterministic and reduce lifecycle script execution during CI.
npm ci --ignore-scriptsinstead ofnpm installin the test jobnpm ci --ignore-scriptsin the publish jobduckdbin the test job because its native binding is required by the existingcsv-issues-esmtestsWhy
Running npm install commands without
--ignore-scriptscan execute package lifecycle scripts. Usingnpm ci --ignore-scriptslimits that behavior and keeps CI installs locked topackage-lock.json.The test suite still needs
duckdb/lib/binding/duckdb.nodefordemo/issues-esm/lib/441.js, so this PR allows only that required native build step explicitly withnpm rebuild duckdb.