Skip to content

Adding rule for epl-2.0 OR lgpl-2.1#4750

Open
CsatariGergely wants to merge 2 commits into
aboutcode-org:developfrom
nokia:rule-epl-2.0-OR-lgpl-2.1
Open

Adding rule for epl-2.0 OR lgpl-2.1#4750
CsatariGergely wants to merge 2 commits into
aboutcode-org:developfrom
nokia:rule-epl-2.0-OR-lgpl-2.1

Conversation

@CsatariGergely

Copy link
Copy Markdown
Contributor

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Updated documentation pages (if applicable)
  • Updated CHANGELOG.rst (if applicable)

Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>

@pombredanne pombredanne left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I added a few suggestions to make the rule more selective.

Comment thread src/licensedcode/data/rules/epl-2.0_or_lgpl-2.1.RULE Outdated
Comment thread src/licensedcode/data/rules/epl-2.0_or_lgpl-2.1.RULE Outdated
Comment thread src/licensedcode/data/rules/epl-2.0_or_lgpl-2.1.RULE Outdated
Co-authored-by: Philippe Ombredanne <pombredanne@aboutcode.org>
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants