fix: show available liquidity for e-mode-only borrowable assets#3032
Open
helpfulBro wants to merge 1 commit into
Open
fix: show available liquidity for e-mode-only borrowable assets#3032helpfulBro wants to merge 1 commit into
helpfulBro wants to merge 1 commit into
Conversation
|
@helpfulBro is attempting to deploy a commit to the Aave Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General Changes
$0on the reserve overview for assets that are only borrowable in E-modeborrowingEnabledisfalse— this extends that logic to also account for E-mode borrowabilityassetIsBorrowableOnMarket()ingetMaxAmountAvailableToBorrow.tsto check whether a reserve is borrowable in normal mode or any E-mode category (mirrors on-chainValidationLogicbehavior)ReserveTopDetails.tsxto use the new helper for the "Available liquidity" displaygetMaxAmountAvailableToBorrow.spec.tsWhy this change?
Some reserves have
borrowingEnabled: falsein normal mode but remain borrowable when a user is in E-mode (via the categoryborrowableBitmap, exposed in the UI aseMode.borrowingEnabled). The reserve overview is market-level, so we show liquidity if the asset is borrowable through any path - not just normal mode.How to verify
borrowingEnabledisfalsebut the asset is borrowable in an E-mode → "Available liquidity" should show the actual USD value$0yarn test getMaxAmountAvailableToBorrowReviewer Checklist
Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.
.env.examplefile as well as the pertinant.github/actions/*files