fix: refresh wallet balances after supply confirmation#3027
Open
alerodriargui wants to merge 1 commit into
Open
fix: refresh wallet balances after supply confirmation#3027alerodriargui wants to merge 1 commit into
alerodriargui wants to merge 1 commit into
Conversation
|
@alerodriargui is attempting to deploy a commit to the Aave Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General Changes
poolTokens(account, market)query used byuseWalletBalancesDeveloper Notes
The supply flow was only invalidating pool data after confirmation, which could leave the wallet balance shown inside the modal stale until the modal was closed and reopened.
This adds a shared
refetchSupplyPoolDatahelper that invalidates pool data and explicitly refetches the active wallet balance query before marking the supply transaction as successful.Validation run locally:
node_modules\.bin\eslint.cmd src/components/transactions/Supply/SupplyActions.tsx src/components/transactions/Supply/SupplyWrappedTokenActions.tsx src/components/transactions/Supply/utils.tsnode_modules\.bin\tsc.cmd --noEmit --pretty falseReviewer Checklist
Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.
.env.examplefile as well as the pertinant.github/actions/*files