fix: resolve uhk-common Buffer import for file: dependencies#2960
Closed
mondalaci wants to merge 1 commit into
Closed
fix: resolve uhk-common Buffer import for file: dependencies#2960mondalaci wants to merge 1 commit into
mondalaci wants to merge 1 commit into
Conversation
uhk-common re-exported Buffer via a relative path into its own node_modules. When uhk-web installs uhk-common as a file: dependency, npm copies the package without nested dependencies, so webpack cannot resolve ../node_modules/buffer/index.js and the renderer build fails. Import Buffer from the buffer package directly. Tighten stringEncoding to a const literal for BufferEncoding compatibility, and wrap the saved user config buffer in Uint8Array for Blob construction. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a renderer build failure when
uhk-webinstallsuhk-commonviafile:../uhk-common.uhk-common/src/buffer.tsre-exportedBufferthrough a relative path into its ownnode_modules:That works when building inside
uhk-common, butnpmcopiesfile:dependencies without nestednode_modules. Webpack then fails:This can surface after any
uhk-webnpm installthat refreshes the localuhk-commoncopy (e.g. adding a dev dependency).Changes
Bufferfrom thebufferpackage directly inuhk-commonUhkBuffer.stringEncodingas'utf8' as constforBufferEncodingtypingUint8ArrayforBlobconstruction in the web rendererTest plan
cd packages/uhk-common && npm run buildrm -rf packages/uhk-web/node_modules/uhk-common && cd packages/uhk-web && npm installrm -rf packages/uhk-web/.angular/cache && npm run build:renderersucceeds.binfrom the web UI still worksMade with Cursor