Add glm4 moe adapter#1424
Open
dylanberens wants to merge 2 commits into
Open
Conversation
…() functions; replace all run_with_cache() calls' positional args w/ keyword args
Collaborator
|
Hi @dylanberens! A couple notes on this one:
Additionally, the intention is to deprecate the HookedTransformers system in 4.x. Until I get around to prepping for that release and auditing to determine which features are covered under TransformerBridge, I won't know for 100% certain what will be dropped and what will be kept. Some of your work may end up deprecated before a release happens, so if you want to wait to do this work until I have a chance to do a feature audit, that is completely acceptable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removed *model_args from 'run_with_cache()' and 'run_with_hooks()' functions, and replaced all those function calls' positional arguments with keyword arguments-- as input= (and inputs= for all audio model calls)
Fixes #798
Type of change
Please delete options that are not relevant.
Screenshots
N/A
Checklist: