Added /audit button to reports (moderation)#1499
Conversation
|
Please add screenshots of the feature and all edge cases in action, makes reviewing it muuuch easier...^^ |
Zabuzard
changed the title
|
Made some changes as you asked. |
|
(please dont resolve comments urself, let the author of the comment do it as confirmation that they consider it done, thanks) |
|
sorry I'm kinda new to this pr stuff |
here are the screenshots too |
|
|
So it shows the last page only now? not sure how i feel about that. the user could have 100 pages and then u show only a single item bc the last page happened to only include one item yet. it should at least show a full page or have buttons i guess. also, shouldnt it be page 1 and not the last? im pretty sure /audit sorts it with the most recent actions shown first, with a full page |
everything works and the pages turn too I forgot to take screenshot 😭 but tested it and it worked just as intended. |
surajkumar
left a comment
surajkumar
left a comment
There was a problem hiding this comment.
Small change but the rest of the PR at my glance looks good. Will be happy to provide the second tick on Zabu's approval
| return new EmbedBuilder().setTitle("Audit log of **%s**".formatted(user.getName())) | ||
| .setAuthor(user.getName(), null, avatarOrDefaultUrl) | ||
| .setDescription(createSummaryMessageDescription(actions)) | ||
| .setDescription(ModerationUtils.createSummaryMessageDescription(actions)) // Redirected |
There was a problem hiding this comment.
This code comment doesn't seem meaningful enough to keep
this time I didn't forget to take screenshots for page turning |
it works I didn't think it would need all the screenshots
|
Made the changes and also changed the name to .json.template this time sorry for the earlier mistake. |
|
and yeah its not the same screenshot every time I take a new one every time I change the code to show that it is tested and works |
| .onErrorFlatMap(_ -> event.getHook() | ||
| .sendMessage("Could not load audit data for this user.") | ||
| .map(msg -> null)) |
There was a problem hiding this comment.
are you sure that works and doesnt crash when its happening?
Tested it with "1234567890L" id and it didn't crash just gave the message and also made it ephemeral because Christolis asked it to be ephemeral. |
|
and also if you like some name changes tell me, I'm not good at naming. |
|
Looked at it thoroughly and changed the names, there might be some that I missed so if any, tell me I'll change them. |
3 participants
Adds a button that lets the moderator that clicked it see the audit log of the reported user.
Resolves #1498