Skip to content

perf: Render ground-aligned particles without sorting #2838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stephanmeesters wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Open

perf: Render ground-aligned particles without sorting #2838

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Core/Libraries/Source/WWVegas/WW3D2/pointgr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -926,8 +926,14 @@ void PointGroupClass::Render(RenderInfoClass &rinfo)
DX8Wrapper::Set_Shader(Shader);
DX8Wrapper::Set_Texture(0,Texture);

// TheSuperHackers @perf stephanmeesters 27/06/2026
// Enable sorting if the primitives are translucent and alpha testing is not enabled.
const bool sort = (Shader.Get_Dst_Blend_Func() != ShaderClass::DSTBLEND_ZERO) && (Shader.Get_Alpha_Test() == ShaderClass::ALPHATEST_DISABLE) && (WW3D::Is_Sorting_Enabled());
// However, do not apply sorting for ground-aligned (i.e. non-billboard) particles.
// This is for performance reasons and because ground-aligned particles do not generally benefit from back-to-front sorting.

@xezon xezon Jun 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also mention the visual improvement?

const bool sort = Billboard &&
Shader.Get_Dst_Blend_Func() != ShaderClass::DSTBLEND_ZERO &&
Shader.Get_Alpha_Test() == ShaderClass::ALPHATEST_DISABLE &&
WW3D::Is_Sorting_Enabled();

IndexBufferClass *indexbuffer;
int verticesperprimitive;/// lorenzen fixed
Expand Down
Loading