Ensure Android PdfView defaults to transparent background when BackgroundColor is unset#9
Draft
Copilot wants to merge 5 commits into
Draft
Ensure Android PdfView defaults to transparent background when BackgroundColor is unset#9Copilot wants to merge 5 commits into
Copilot wants to merge 5 commits into
Conversation
Agent-Logs-Url: https://github.com/TheEightBot/MauiNativePdfView/sessions/79d2da60-a88c-42cf-bb98-58d306d9edd2 Co-authored-by: michaelstonis <120685+michaelstonis@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix row 0 display issue when BackgroundColor is not set
Ensure Android PdfView defaults to transparent background when BackgroundColor is unset
Apr 22, 2026
The BackgroundColor setter's Color.Argb(...) call was missing its Blue argument and closing paren, leaving the ternary ':' where the 4th argument belongs. This caused CS1525/CS1026 and made the library unbuildable for net9.0-android. Complete the ARGB call and fix the indentation of the trailing SetBackgroundColor/Invalidate statements. No behavior change beyond making the project compile. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Adds a dedicated, toggle-driven repro harness (LayoutReproPage) for validating layering issues such as GitHub issue #8 (content overlapping a PdfView hidden unless BackgroundColor is set; scroll-time flicker). Controls: - Layout: Overlay (header shares the PdfView cell — the #8 repro) vs Stacked (separate row — the control case). - Background: cycle (unset) -> Transparent -> White to demonstrate the default-transparent behavior added in 328b7aa. - Header ZIndex: toggle the commenter's flicker workaround. Wires both pages into a Shell flyout and makes Repro Lab the landing page. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
PdfViewis placed in aGridon Android, leavingBackgroundColorunset could cause row 0 content to be visually obscured. Explicitly settingBackgroundColor="Transparent"worked around it; this change makes that behavior the default.Android native background initialization
PDFViewbackground to transparent at construction time so unset MAUI background does not inherit problematic native defaults.Consistent null-background mapping
BackgroundColormapping to always apply a native color:nullMAUI background →Android.Graphics.Color.TransparentBehavioral impact
BackgroundColor="Transparent"to avoid Grid row 0 visibility issues.