Skip to content

Fix project name prompt placeholder leak#466

Draft
tannerlinsley wants to merge 1 commit into
mainfrom
taren/fix-create-name-placeholder
Draft

Fix project name prompt placeholder leak#466
tannerlinsley wants to merge 1 commit into
mainfrom
taren/fix-create-name-placeholder

Conversation

@tannerlinsley
Copy link
Copy Markdown
Member

Summary

Fixes the interactive project-name prompt so pressing Enter for the current directory no longer lets the placeholder text leak into validation.

Details

The prompt used Clack's placeholder for the current-directory hint. In this edge case, the placeholder could be treated like input after Enter, then validated as a project name and duplicated in the prompt output. The hint now lives in the prompt message, and the project-name prompt no longer sets a placeholder.

Validation

  • pnpm --filter @tanstack/cli test -- ui-prompts
  • pnpm --filter @tanstack/cli build
  • Commit hook: nx run-many --target=build --parallel 5
  • Commit hook: pnpm test:unit && pnpm test:e2e

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 7, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d0574177-8c48-4648-b572-c68f27d200d7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch taren/fix-create-name-placeholder

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant