Clean up legacy code and artifacts#41
Merged
Merged
Conversation
Remove the pre-overhaul, config-driven mapper implementation and its examples from the repository. Full history is preserved at the `mapper-legacy` git tag. - Delete `src/knowledge_mapper/legacy/` (old mapper, data sources, auth, wizard, etc.) - Delete `examples/legacy/` (old Docker-based examples) - Delete `setup.py` — build is configured in `pyproject.toml` - Remove ruff exclusions for the deleted legacy paths - Remove the Legacy Code sections from CONTEXT.md and CONTRIBUTING.md and drop the legacy entries from CONTEXT.md's project layout Closes #38 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #38
Removes the pre-overhaul, config-driven mapper implementation and its examples from the repository. Full history is preserved at the
mapper-legacygit tag.Changes
Deleted:
src/knowledge_mapper/legacy/— the old mapper, data sources, auth, wizard, etc.examples/legacy/— the old Docker-based examplessetup.py— build configuration lives inpyproject.tomlUpdated:
pyproject.toml— dropped the ruffexcludeentries for the deleted legacy pathsCONTEXT.md— removed theLegacy Codesection, removed the legacy entries from the project-layout tree, and dropped the "legacy dirs excluded" note from the ruff lineCONTRIBUTING.md— removed the now-staleLegacy Codesection that pointed contributors at the deleted directories (tightly coupled to this change)Per the issue, README references to the legacy overhaul are intentionally left alone — those are scoped to the README rewrite (#36).
Acceptance criteria
src/knowledge_mapper/legacy/deletedexamples/legacy/deletedsetup.pydeletedpyproject.tomlno longer excludes legacy dirs from ruffCONTEXT.mdno longer references legacy directoriesknowledge_mapper.legacyremain (verified via grep)uv run pytest— 97 passeduv run ruff check .— all checks passed