Conversation
Replace direct authSession.handleIncomingRedirect usage with authn.checkUser in the dev entrypoint.\nUse a session-shape-safe logged-in check so both legacy and uvdsl-backed sessions work.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the dev entrypoint login finalization logic to use the authn compatibility flow, aiming to support both legacy and newer session shapes.
Changes:
- Replaced
authSession.handleIncomingRedirect()withauthn.checkUser()in the dev login flow. - Added a “session-shape-safe” logged-in check using multiple possible session fields.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
13
to
18
| await authn.checkUser() | ||
| const session = authSession | ||
| if (session.info.isLoggedIn) { | ||
| const isLoggedIn = session?.info?.isLoggedIn ?? session?.isActive ?? Boolean(session?.webId) | ||
| if (isLoggedIn) { | ||
| // Update the page with the status. | ||
| webId.innerHTML = 'Logged in as: ' + authn.currentUser().uri |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace direct authSession.handleIncomingRedirect usage with authn.checkUser in the dev entrypoint.\nUse a session-shape-safe logged-in check so both legacy and uvdsl-backed sessions work.