chore: migrate weather app to standalone repo#852
Conversation
- remove source files from edge-apps/weather - add redirect notice in edge-apps/weather/README.md - relocate icon to edge-apps/icons/weather.svg - update README.md to link to Screenly/weather-edge-app
PR Reviewer Guide 🔍(Review updated until commit 902fc3e)Here are some key observations to aid the review process:
|
|
Persistent review updated to latest commit 902fc3e |
PR Code Suggestions ✨No code suggestions found for the PR. |
1 similar comment
PR Code Suggestions ✨No code suggestions found for the PR. |
There was a problem hiding this comment.
Pull request overview
This PR migrates the Weather Edge App out of the Playground monorepo by removing its implementation, tests, and build/manifest configuration, while leaving behind documentation pointers to the standalone repository.
Changes:
- Remove
edge-apps/weathersource code, unit tests, and e2e screenshot tests. - Remove Weather app build/config/manifest files (Bun/TS/Screenly manifests).
- Update documentation to point users to the standalone weather repository and add a Weather icon asset under
edge-apps/icons/.
Reviewed changes
Copilot reviewed 16 out of 35 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updates the Weather app entry in the Edge Apps list to link to the standalone repository. |
| edge-apps/icons/weather.svg | Adds a Weather icon asset alongside other Edge App icons. |
| edge-apps/weather/.gitignore | Removes app-specific gitignore as the app is no longer built/tested here. |
| edge-apps/weather/.ignore | Removes app-specific ignore file. |
| edge-apps/weather/README.md | Replaces Weather app documentation with a migration notice and link. |
| edge-apps/weather/bun.lock | Removes the Weather app lockfile. |
| edge-apps/weather/e2e/screenshots.spec.ts | Removes Weather Playwright screenshot tests. |
| edge-apps/weather/e2e/weather-mocks.ts | Removes OpenWeather mock data used by e2e screenshots. |
| edge-apps/weather/index.html | Removes the Weather app HTML shell. |
| edge-apps/weather/package.json | Removes Weather app package scripts/config. |
| edge-apps/weather/screenly.yml | Removes the Weather production manifest. |
| edge-apps/weather/screenly_qc.yml | Removes the Weather QC manifest. |
| edge-apps/weather/src/background.ts | Removes Weather background selection logic. |
| edge-apps/weather/src/css/style.css | Removes Weather app styling. |
| edge-apps/weather/src/main.ts | Removes the Weather app runtime entrypoint. |
| edge-apps/weather/src/weather.test.ts | Removes Weather service unit tests. |
| edge-apps/weather/src/weather.ts | Removes Weather data fetching/formatting module. |
| edge-apps/weather/static/images/sun.svg | Removes a Weather static asset as part of app removal. |
| edge-apps/weather/tsconfig.json | Removes Weather app TypeScript config. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
User description
Removes source files from
edge-apps/weatherand redirects to Screenly/weather-edge-app. Closes #843.PR Type
Other, Documentation
Description
Remove weather app source and manifests
Remove weather tests and mocks
Add standalone repository redirect notice
Update root weather app link
Diagram Walkthrough
File Walkthrough
3 files
Remove weather screenshot test suiteRemove OpenWeather screenshot mock fixturesRemove weather service unit tests5 files
Remove weather background selection logicRemove weather app runtime entrypointRemove weather API integration logicRemove weather app stylesheetRemove weather app HTML shell2 files
Update weather listing to standalone repoReplace documentation with repository redirect4 files
Remove weather-specific ignore configurationRemove production Screenly app manifestRemove QC Screenly app manifestRemove weather TypeScript configuration1 files
Remove weather package scripts and dependencies16 files