Skip to content

chore: migrate weather app to standalone repo#852

Merged
nicomiguelino merged 2 commits into
masterfrom
chore/remove-weather-app
Jun 25, 2026
Merged

chore: migrate weather app to standalone repo#852
nicomiguelino merged 2 commits into
masterfrom
chore/remove-weather-app

Conversation

@nicomiguelino

@nicomiguelino nicomiguelino commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

User description

Removes source files from edge-apps/weather and redirects to Screenly/weather-edge-app. Closes #843.


PR Type

Other, Documentation


Description

  • Remove weather app source and manifests

  • Remove weather tests and mocks

  • Add standalone repository redirect notice

  • Update root weather app link


Diagram Walkthrough

flowchart LR
  A["Playground weather app"] -- "source removed" --> B["edge-apps/weather redirect"]
  B -- "points users to" --> C["Screenly/weather-edge-app"]
  D["Root README"] -- "updates listing link" --> C
Loading

File Walkthrough

Relevant files
Tests
3 files
screenshots.spec.ts
Remove weather screenshot test suite                                         
+0/-96   
weather-mocks.ts
Remove OpenWeather screenshot mock fixtures                           
+0/-370 
weather.test.ts
Remove weather service unit tests                                               
+0/-277 
Miscellaneous
5 files
background.ts
Remove weather background selection logic                               
+0/-40   
main.ts
Remove weather app runtime entrypoint                                       
+0/-228 
weather.ts
Remove weather API integration logic                                         
+0/-139 
style.css
Remove weather app stylesheet                                                       
+0/-341 
index.html
Remove weather app HTML shell                                                       
+0/-76   
Documentation
2 files
README.md
Update weather listing to standalone repo                               
+1/-1     
README.md
Replace documentation with repository redirect                     
+2/-54   
Configuration changes
4 files
.ignore
Remove weather-specific ignore configuration                         
+0/-1     
screenly.yml
Remove production Screenly app manifest                                   
+0/-91   
screenly_qc.yml
Remove QC Screenly app manifest                                                   
+0/-91   
tsconfig.json
Remove weather TypeScript configuration                                   
+0/-8     
Dependencies
1 files
package.json
Remove weather package scripts and dependencies                   
+0/-35   
Additional files
16 files
1080x1920.webp [link]   
1280x720.webp [link]   
1920x1080.webp [link]   
2160x3840.webp [link]   
2160x4096.webp [link]   
3840x2160.webp [link]   
4096x2160.webp [link]   
480x800.webp [link]   
720x1280.webp [link]   
800x480.webp [link]   
no-api-key-2160x3840.webp [link]   
no-api-key-3840x2160.webp [link]   
bg-cloudy.webp [link]   
bg-rainy.webp [link]   
bg-snow.webp [link]   
bg-sunny.webp [link]   

- remove source files from edge-apps/weather
- add redirect notice in edge-apps/weather/README.md
- relocate icon to edge-apps/icons/weather.svg
- update README.md to link to Screenly/weather-edge-app
@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown

PR Reviewer Guide 🔍

(Review updated until commit 902fc3e)

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis 🔶

843 - Partially compliant

Compliant requirements:

  • Remove the weather app source, manifests, tests, and related files from the monorepo.
  • Leave users with a clear redirect/reference to the standalone repository.

Non-compliant requirements:

  • Use Screenly/weather-app as the target standalone repository.

Requires further human verification:

  • Confirm the actual weather app contents have been migrated to the standalone repository.
⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

@github-actions

Copy link
Copy Markdown

Persistent review updated to latest commit 902fc3e

@github-actions

Copy link
Copy Markdown

PR Code Suggestions ✨

No code suggestions found for the PR.

1 similar comment
@github-actions

Copy link
Copy Markdown

PR Code Suggestions ✨

No code suggestions found for the PR.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the Weather Edge App out of the Playground monorepo by removing its implementation, tests, and build/manifest configuration, while leaving behind documentation pointers to the standalone repository.

Changes:

  • Remove edge-apps/weather source code, unit tests, and e2e screenshot tests.
  • Remove Weather app build/config/manifest files (Bun/TS/Screenly manifests).
  • Update documentation to point users to the standalone weather repository and add a Weather icon asset under edge-apps/icons/.

Reviewed changes

Copilot reviewed 16 out of 35 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
README.md Updates the Weather app entry in the Edge Apps list to link to the standalone repository.
edge-apps/icons/weather.svg Adds a Weather icon asset alongside other Edge App icons.
edge-apps/weather/.gitignore Removes app-specific gitignore as the app is no longer built/tested here.
edge-apps/weather/.ignore Removes app-specific ignore file.
edge-apps/weather/README.md Replaces Weather app documentation with a migration notice and link.
edge-apps/weather/bun.lock Removes the Weather app lockfile.
edge-apps/weather/e2e/screenshots.spec.ts Removes Weather Playwright screenshot tests.
edge-apps/weather/e2e/weather-mocks.ts Removes OpenWeather mock data used by e2e screenshots.
edge-apps/weather/index.html Removes the Weather app HTML shell.
edge-apps/weather/package.json Removes Weather app package scripts/config.
edge-apps/weather/screenly.yml Removes the Weather production manifest.
edge-apps/weather/screenly_qc.yml Removes the Weather QC manifest.
edge-apps/weather/src/background.ts Removes Weather background selection logic.
edge-apps/weather/src/css/style.css Removes Weather app styling.
edge-apps/weather/src/main.ts Removes the Weather app runtime entrypoint.
edge-apps/weather/src/weather.test.ts Removes Weather service unit tests.
edge-apps/weather/src/weather.ts Removes Weather data fetching/formatting module.
edge-apps/weather/static/images/sun.svg Removes a Weather static asset as part of app removal.
edge-apps/weather/tsconfig.json Removes Weather app TypeScript config.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread README.md Outdated
Comment thread edge-apps/weather/README.md Outdated
@nicomiguelino nicomiguelino merged commit 536a343 into master Jun 25, 2026
5 checks passed
@nicomiguelino nicomiguelino deleted the chore/remove-weather-app branch June 25, 2026 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: migrate edge-apps/weather to standalone repo (Screenly/weather-app)

3 participants