Generalize the Data object#28
Closed
krzywon wants to merge 15 commits into
Closed
Conversation
… to be removed in future versions of sasdata
…(instrument and sample) classes to their own python file
… (Plottable) that all plottable objects inherit from. Add subclasses for 1D, 2D, SESANS, and Slit-Smeared data
… all data objects inherit from
…precation warnings
Contributor
|
Cool, I have a workshop tomorrow and Friday, but I might find some time to look somewhere. |
Contributor
|
I think its going in the right direction. Would be good to have a chat about it soon. |
… behavior to log warnings instead of throwing errors.
…mpatibility and deprecation purposes. Added type hinting, py2->py3 fixes, and deprecation warnings and documentation.
…7-generalize-1d-2d-data
Member
|
Working on cleanup in preparation for Contributor Camp XII: @krzywon I'm assuming this kind of change should probably go into 6.0? in which case we may need to prioritize it as such? or is that not the case? |
Collaborator
Author
Ideally, yes, but realistically, probably won't make it in. |
Collaborator
Author
|
Superseded by #79 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@lucas-wilkins - this is a start to what I am imagining for how the data object should be refactored. I need this to finish the separation of SasView/sasview#1802 related to unit conversions but want a third set of eyes (@pkienzle already took a quick look and gave his input) to take a look at the direction I am taking.
Once finished, this will fix #17, and fix #19.