Windows native support (with Microsoft Visual Studio)#918
Conversation
tridge
left a comment
There was a problem hiding this comment.
thanks!
Please add a CI job as well to test this, preferably with it running the test suite
- Implements �uto-win-msvc compatibility\n- Updates CMakeLists.txt to support FetchContent and fallback ZLIB
|
@SamuelMarks wo, we really get a native windows rsync port, i.e. we can really run this without cygwin or WSL? but wouldn't this need some little description/announcement or further information , what's being added here and in which way it probably differs from unix rsync? what about path names ("" vs "/") , drive letters and such ? |
|
@SamuelMarks where is the auto-win-msvc shim layer referenced by config.h.in? |
|
@tridge https://github.com/SamuelMarks/auto-win-msvc Bringing rsync (and other ported projects) into the CI; so when that passes we should have some degree of confidence. @devZer0 still plenty of testing to be done; particularly the introduction of new tests. Lots of Windows stuff is annoying (UTF 16 with BOM on paths that need allocation; UNC paths ; etc.). |
Which will produce a neat 2MB rsync.exe. Release mode gives a 440KB rsync.exe.