Migrate project template to v1.2.0#129
Merged
Merged
Conversation
- Add publish dry-run step to verify.sh and verify.ps1 - Bump template-version.txt from 1.1.1 to 1.1.2
- Improve verify.sh / verify.ps1 with root-switching, error aggregation, RUSTDOCFLAGS restore, and non-zero exit on failure - Add .vscode/settings.json to disable YAML format-on-save - Add crates.io keywords/categories placeholders to all Cargo.toml files - Fix panic = abort comment wording - Update template version marker to 1.1.3
- Rename `format` job to `format-check` - Add repo-relative comment headers to verify scripts - Bump template version marker to 1.1.4
Migrate template version marker from v1.1.4 to v1.1.5 per migration docs.
WalkthroughThis PR refactors the Rust project's verification pipeline to aggregate command failures instead of aborting immediately. Both Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/rust.yml (1)
144-153:⚠️ Potential issue | 🟠 Major | ⚡ Quick winRestrict
GITHUB_TOKENpermissions forformat-check.
format-checkonly needs repository read access, but currently inherits default permissions. Tightening this reduces blast radius for third-party/action-chain compromise.Proposed fix
format-check: + permissions: + contents: read runs-on: ubuntu-latest steps: - uses: actions/checkout@v6🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/rust.yml around lines 144 - 153, The format-check job currently inherits default GITHUB_TOKEN permissions; restrict it by adding an explicit permissions block for the job named format-check to give only repository read access (e.g., set contents: read) so the actions-rust-lang/rustfmt step and actions/checkout only get minimal rights; update the format-check job configuration (referencing the job name "format-check" and the steps using "actions/checkout@v6" and "actions-rust-lang/rustfmt@v1") to include the minimal permissions declaration.Source: Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In @.github/workflows/rust.yml:
- Around line 144-153: The format-check job currently inherits default
GITHUB_TOKEN permissions; restrict it by adding an explicit permissions block
for the job named format-check to give only repository read access (e.g., set
contents: read) so the actions-rust-lang/rustfmt step and actions/checkout only
get minimal rights; update the format-check job configuration (referencing the
job name "format-check" and the steps using "actions/checkout@v6" and
"actions-rust-lang/rustfmt@v1") to include the minimal permissions declaration.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 236b0e4b-f1ff-4233-b010-ffb71cfedb17
📒 Files selected for processing (37)
.github/template-version.txt.github/workflows/deploy-mkdocs.yml.github/workflows/rust.yml.vscode/settings.jsonsrc/.cargo/verify.ps1src/.cargo/verify.shsrc/docs/.gitignoresrc/docs/mkdocs.ymlsrc/docs/requirements.txtsrc/docs/src/agents.mdsrc/docs/src/architecture.mdsrc/docs/src/assets/landing.csssrc/docs/src/comparison.mdsrc/docs/src/examples.mdsrc/docs/src/extra-sandboxing-notes.mdsrc/docs/src/feature-flags.mdsrc/docs/src/getting-started.mdsrc/docs/src/guides/custom-framework.mdsrc/docs/src/guides/custom-providers.mdsrc/docs/src/hooks.mdsrc/docs/src/index.mdsrc/docs/src/migration.mdsrc/docs/src/models-catalog.mdsrc/docs/src/sandboxing.mdsrc/docs/src/tools.mdsrc/docs/src/vendor/Reloaded/Images/Nexus-Heart-40.avifsrc/docs/src/vendor/Reloaded/Images/Nexus-Icon-40.avifsrc/docs/src/vendor/Reloaded/Images/Reloaded-Heart-40.avifsrc/docs/src/vendor/Reloaded/Images/Reloaded-Icon-40.avifsrc/docs/src/vendor/Reloaded/Stylesheets/reloaded.csssrc/docs/start_docs.pysrc/reloaded-code-agents/Cargo.tomlsrc/reloaded-code-bubblewrap/Cargo.tomlsrc/reloaded-code-core/Cargo.tomlsrc/reloaded-code-models-dev/Cargo.tomlsrc/reloaded-code-provider-config/Cargo.tomlsrc/reloaded-code-serdesai/Cargo.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
docs/intosrc/docs/per migration guide. Updatesdeploy-mkdocs.ymlandtemplate-version.