fix: benchmarkMode=time respect minSamples#165
Open
gusanthiago wants to merge 5 commits into
Open
Conversation
RafaelGSS
reviewed
Jun 27, 2026
gusanthiago
force-pushed
the
bugfix/adjust-minSamples
branch
from
80ab0d0 to
417a737
Compare
* Create collectSamplesOfTimeMode to can record minSamples ignoring time * Create tests of minSamples with benchmarkMode: time
gusanthiago
force-pushed
the
bugfix/adjust-minSamples
branch
from
ccf9bdd to
b560216
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hello guys, this PR should close issue #130
Proposed Changes
minSamples: each sample is one independent execution of the benchmark function, collected untilminSamplesis reached per round.totalTimereports the mean execution time across all collected samples (not averaged perrepeatSuiteround).iterationsreflects the total number of samples collected (minSamples×repeatSuite).minSamplesalone and combined withrepeatSuite.index.d.ts,examples/time-mode.js.Test plan
npm test -- test/time-mode.js— new tests pass:node --allow-natives-syntax examples/time-mode.js