Apply reformat shortcut to hardware frames too#2323
Open
CarlosRDomin wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small follow-up to #2321
When
VideoFrame.reformatis called on a hardware frame, PyAV first downloads it into a software frame. If that downloaded frame already matches the requested output format, size, colorspace and color range, we can return it directly instead of passing it through swscale. This avoids unnecessary e.g.nv12 -> nv12swscale conversions after hardware download, which besides being inefficient actually modify pixel values even though no format/size conversion is requested. Without my change toreformatter.py, the test I introduce intest_decode.pyfails on the latest PyAV (bothmainand 17.1.0).The included test compares:
is_hw_owned=False, which PyAV downloads directly, andis_hw_owned=Trueand then reformatted to the same software format.With the shortcut, both paths preserve identical pixel data and the test passes.