'Почему-то запущено много сесий с контейнером браузера'#387
Conversation
Adding .gitkeep for PR creation (default mode). This file will be removed when the task is complete. Issue: ProverCoderAI#383
|
Warning Review limit reached
More reviews will be available in 54 minutes and 10 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Working session summaryImplemented the fix locally, but I could not commit/push/update PR #387 because command execution stopped working after an Changed:
Verified:
Blocked:
This summary was automatically extracted from the AI working session output. |
konard
changed the title
🤖 Solution Draft LogThis log file contains the complete execution trace of the AI solution draft process. 💰 Cost estimation:
📊 Context and tokens usage:
Total: (340.6K + 5.1M cached) input tokens, 17.2K output tokens, $9.323500 cost 🤖 Models used:
📎 Log file uploaded as Gist (20878KB)Now working session is ended, feel free to review and add any feedback on the solution draft. |
🚨 Solution Draft FailedThe automated solution draft encountered an error: 🤖 Models used:
📎 Failure log uploaded as Gist (21400KB)Now working session is ended, feel free to review and add any feedback on the solution draft. |
|
Исправь весь код |
|
🤖 AI Work Session Started Starting automated work session at 2026-06-10T10:18:23.471Z The PR has been converted to draft mode while work is in progress. This comment marks the beginning of an AI work session. Please wait for the session to finish, and provide your feedback. |
The Rust browser MCP helpers (`browser-connection` / `docker-git-browser-connection`) run on an allocated pty, so `hasInteractiveTty` classified each one as a visible `ssh` terminal. That flooded the container task manager with many identical `browser-connection --project ... --network container:...` rows (issue ProverCoderAI#383). Classify these helper processes as internal `system` tasks so they are hidden by default (includeDefault=false) and only shown when system processes are explicitly requested. Fixes ProverCoderAI#383
Working session summaryThe background CI-wait task has completed, confirming all runs on commit
This summary was automatically extracted from the AI working session output. |
🤖 Solution Draft LogThis log file contains the complete execution trace of the AI solution draft process. 💰 Cost: $2.213011📊 Context and tokens usage:
Total: (3.3K new + 60.9K cache writes + 2.7M cache reads) input tokens, 18.9K output tokens, $2.213012 cost 🤖 Models used:
📎 Log file uploaded as Gist (1586KB)Now working session is ended, feel free to review and add any feedback on the solution draft. |
|
🤖 AI Work Session Completed Work session ended at 2026-06-10T10:44:06.219Z The PR will be converted back to ready for review. This comment marks the end of an AI work session. New comments after this time will be considered as feedback. |
2 participants
Summary
Fixes #383 — the container task manager was flooded with many identical sessions for the browser container.
Root cause
The Rust browser MCP helpers (
browser-connection/docker-git-browser-connection) run on an allocated pty (pts/N). InclassifyProcess, any non-baseline process with an interactive tty falls through to thesshkind, so every helper showed up as a separate visiblesshterminal:Fix
packages/api/src/services/container-tasks-core.tsnow classifies these helper processes as internalsystemtasks. SincebuildContainerTasks(..., includeDefault=false)filters outsystemtasks, they no longer clutter the task manager and are only surfaced when system processes are explicitly requested.Reproduction & test
packages/api/tests/container-tasks-core.test.tsadds a regression test mirroring the command shape from the issue screenshot:browser-connection ... --network container:...process onpts/1and a/usr/local/bin/docker-git-browser-connection startprocess are now excluded from the default task list.includeDefault=truethe helper is reported with kindsystem(notssh).Verified the test fails against the old classifier (helper classified as
ssh) and passes with the fix.Checks
vitest runforcontainer-tasks-core+project-browser: passing.tsc --noEmit(api typecheck): passing.eslinton changed files: passing.Changes
packages/api/src/services/container-tasks-core.ts: classifybrowser-connection/docker-git-browser-connectionhelpers assystem.packages/api/tests/container-tasks-core.test.ts: regression test..gitkeep.Fixes #383