feat(triton): add embed and chatComplete support#1677
Open
goingforstudying-ctrl wants to merge 1 commit into
Open
feat(triton): add embed and chatComplete support#1677goingforstudying-ctrl wants to merge 1 commit into
goingforstudying-ctrl wants to merge 1 commit into
Conversation
- Add TritonEmbedConfig and TritonEmbedResponseTransform for /v1/embeddings - Add TritonChatCompleteConfig, TritonChatCompleteResponseTransform, and TritonChatCompleteStreamChunkTransform for /v1/chat/completions - Update TritonAPIConfig with endpoints for chatComplete and embed - Register new transforms in TritonConfig index Fixes Portkey-AI#1189
Author
|
Hi, just checking in on this PR. It has been a few days since the last update. Please let me know if there is anything else needed from my side to move this forward. Thanks for your time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for embeddings and chat completions to the Triton inference server provider, which were previously returning "is not supported by triton" errors.
Changes
TritonEmbedConfigandTritonEmbedResponseTransformfor/v1/embeddingsTritonChatCompleteConfig,TritonChatCompleteResponseTransform, andTritonChatCompleteStreamChunkTransformfor/v1/chat/completionsTritonAPIConfigto routechatCompleteandembedto the correct OpenAI-compatible endpointsTritonConfigTest Plan
Fixes #1189