Skip to content

Begin adding Sword/Shield encounters#1550

Draft
jemarq04 wants to merge 40 commits into
PokeAPI:masterfrom
jemarq04:feat/add-part-sword-shield-encounters
Draft

Begin adding Sword/Shield encounters#1550
jemarq04 wants to merge 40 commits into
PokeAPI:masterfrom
jemarq04:feat/add-part-sword-shield-encounters

Conversation

@jemarq04

@jemarq04 jemarq04 commented Jun 9, 2026

Copy link
Copy Markdown
Member

Change description

This is the first in a series of PRs adding encounters for the sword-shield version group as a follow-up to #1459. I'm trying to chunk them up into pieces that are easier to review, and this felt like a good break in my current progress. I'll make more PRs as I make more progress later on. I'm skipping Wild Areas and gift/trades until later PRs.

This PR contains encounters for Route 1-5, Wedgehurst, Motostoke, Turffield, Hulbury, Galar Mine, Galar Mine No. 2, and Motostoke Outskirts. New location areas (and their prose) were added as well. Lastly, a new encounter method was added (fishing) since this game doesn't have old/good/super rods.

I did rename the berry-piles encounter method to berry-trees, since the piles were always at trees in Alola and Galar only has trees. This was just so that this one method could be used for both games without adding a new one.

All of this was done with a custom interactive helper script, no AI used. Some human error may have been introduced then, but I tried to double-check each location area as I added them. If we need to hold off to merge other encounter PRs, I have some code to increment my encounter IDs.

Contributor check list

  • I have written a description of the contribution and explained its motivation.
  • I have written tests for my code changes (if applicable).
  • I have read and understood the AI Assisted Contribution guidelines.
  • I will own this change in production, and I am prepared to fix any bugs caused by my code change.

jemarq04 added 30 commits June 8, 2026 10:11
@jemarq04 jemarq04 marked this pull request as draft June 9, 2026 23:19
@jemarq04

jemarq04 commented Jun 9, 2026

Copy link
Copy Markdown
Member Author

I just encountered a location area (glimwood-tangle) that can't use the encounter slots I set up... I need to re-distribute the encounter slots and re-do these encounters. :(

@Naramsim

Copy link
Copy Markdown
Member

Great additions @jemarq04 . Did you scrape the data from the internet or by looking into some game files?

@Naramsim

Copy link
Copy Markdown
Member

I just encountered a location area (glimwood-tangle) that can't use the encounter slots I set up... I need to re-distribute the encounter slots and re-do these encounters. :(

Ouch, I'm sorry!

@jemarq04

Copy link
Copy Markdown
Member Author

Great additions @jemarq04 . Did you scrape the data from the internet or by looking into some game files?

I just looked through Serebii/Bulbapedia pages and inputted values into my script which translated them into entries into encounters.csv. The hardest part was determining the shared encounter slots for the game, which I've found to be incorrect twice now lol

I did notice though that in the API, we have multiple sets of encounter slots for black and white with varying encounter rates instead of one set of slots used by each area. It wouldn't be accurate to the in-game encounter slots, but functionally it would give us accurate encounters in each location area.
If organizing the slots that way is good with you @Naramsim, then I can easily edit my script and get these encounters in. Otherwise I'll need to take more time to design the slots to work with every location area encounter in the game before making any PRs.

(I'll also ping @notblisy, since they've done a lot of Pokemon RNG stuff and may know about the specifics of sword/shield encounter slots.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants