Send the transaction amount to Paystack as an integer number of kobo#70
Open
iammcoding wants to merge 1 commit into
Open
Send the transaction amount to Paystack as an integer number of kobo#70iammcoding wants to merge 1 commit into
iammcoding wants to merge 1 commit into
Conversation
The amount was calculated as $order->getGrandTotal() * 100. Grand totals
are floating point, so multiplying by 100 introduces the usual float
representation error and the value is then JSON encoded and sent to
Paystack as a fractional number.
For example a 19.99 order total becomes 1998.9999999999998 instead of
1999, and is sent as {"amount":1998.9999999999998}. Paystack expects the
amount in the currency subunit (kobo) as an integer, so a fractional
amount is either rejected or truncated, which undercharges the customer.
Other common totals hit this too: 1.10 -> 110.00000000000001,
0.29 -> 28.999999999999996, 8.21 -> 821.0000000000001.
Wrapping the calculation in (int) round(...) sends a correct integer
amount for every total.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The amount was calculated as $order->getGrandTotal() * 100. Grand totals are floating point, so multiplying by 100 introduces the usual float representation error and the value is then JSON encoded and sent to Paystack as a fractional number.
For example a 19.99 order total becomes 1998.9999999999998 instead of 1999, and is sent as {"amount":1998.9999999999998}. Paystack expects the amount in the currency subunit (kobo) as an integer, so a fractional amount is either rejected or truncated, which undercharges the customer. Other common totals hit this too: 1.10 -> 110.00000000000001, 0.29 -> 28.999999999999996, 8.21 -> 821.0000000000001.
Wrapping the calculation in (int) round(...) sends a correct integer amount for every total.