Fallback to id field when name is missing in Minecraft velo plugin parsing#286
Open
Zoriot wants to merge 1 commit into
Open
Fallback to id field when name is missing in Minecraft velo plugin parsing#286Zoriot wants to merge 1 commit into
id field when name is missing in Minecraft velo plugin parsing#286Zoriot wants to merge 1 commit into
Conversation
Osiris-Team
requested changes
Jun 25, 2026
Owner
There was a problem hiding this comment.
Hey thanks for the PR! Very nice, just some small things:
- please keep the comment you removed, it should still be applicable
- please add a check for null/empty json element and add a nice exception with a better error message than the default json one right now if it fails in either case. While we are at it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #285.