Skip to content

fix(x402): require a real task in storefront buy prompts#650

Open
HananINouman wants to merge 2 commits into
mainfrom
fix/storefront-buy-prompts
Open

fix(x402): require a real task in storefront buy prompts#650
HananINouman wants to merge 2 commits into
mainfrom
fix/storefront-buy-prompts

Conversation

@HananINouman

@HananINouman HananINouman commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Stop copy-paste prompts that pay for empty HTTP/agent calls. Align 402 HTML and public-storefront ServiceCard text so buyers include a request body or user message before spending.

Summary

Screenshot 2026-06-17 at 12 28 29 AM

Why it matters:

Risk level:

Commit under test:

Base branch:

Scope

  • Code
  • Charts / manifests
  • Flows / QA scripts
  • Docs / skills
  • Images / dependencies
  • Other:

Validation

CI checks:

Check Status Link

Unit tests:

<!-- command, result, commit/SHA -->

Integration tests:

<!-- command, result, commit/SHA -->

Flow tests:

Flow Network QA machine label Worktree Result Artifacts

Release smoke:

<!-- command, flags, result -->

Live Chain Evidence

Do not include private keys, seed phrases, passwords, hostnames, personal paths, or raw bearer tokens.

Network:

RPC/provider:

Facilitator:

Contracts and tokens:

Name Address Version / notes

Wallet roles:

Role Address Source
Alice / seller / register
Bob / buyer / payer
Facilitator / receiver

Balances:

Token Address Before After Expected delta Actual delta

Transaction receipts:

Purpose Tx hash From To Amount / event Status
ERC-8004 registration
Metadata / service offer
Approval / permit
Purchase request
Settlement transfer

Runtime Evidence

QA environment:

Item Value
OS / arch
Backend
Tool versions
QA agent/model

Images:

Component Image Tag / digest Source

Kubernetes / stack:

Item Value
Stack IDs
Namespaces
Pod readiness
Cleanup result

Model and routing:

Item Value
Agent/model used
LiteLLM route
Paid endpoint status
Auth token source

Artifacts and logs:

Artifact Location / link Notes

Demo readiness:

Item Status Notes
Seller visible / registered
Buyer discovery works
Paid route works
Settlement visible on-chain

Review Notes

Known gaps:

Follow-ups:

Reviewer focus:

Stop copy-paste prompts that pay for empty HTTP/agent calls. Align 402 HTML
and public-storefront ServiceCard text so buyers include a request body or
user message before spending.

Co-authored-by: Cursor <cursoragent@cursor.com>
@HananINouman HananINouman requested a review from OisinKyne June 16, 2026 21:30
Pin npm lockfile after dependency install so storefront Docker builds are reproducible.

Co-authored-by: Cursor <cursoragent@cursor.com>
@HananINouman HananINouman marked this pull request as draft June 16, 2026 21:37
@HananINouman HananINouman marked this pull request as ready for review June 17, 2026 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant