Add a real regression test for one-file-per-signal Intan digital streams#1862
Merged
Merged
Conversation
alejoe91
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on #1854: we have now the test data on gin for this case, so this swaps the synthetic demultiplex test for a real one that reads the file end to end and checks the digital streams against the raw
.datdata.While in there I also made a small improvement to
_demultiplex_digital_data: it used to unpack the whole recording for every channel and slice at the end, so I moved the slice up front so it only unpacks the requested samples. This will save memory for chunked call.