Draft multigpu ci for github from codex#1790
Conversation
|
/ok to test 0341d7e |
Greptile SummaryThis PR adds a complete multi-GPU CI system for GitHub Actions, including a Python script (
Important Files Changed
Reviews (1): Last reviewed commit: "Draft multigpu ci for github from codex" | Re-trigger Greptile |
| files_payload=_load_optional_json(args.files_json), | ||
| manifests=manifests, |
There was a problem hiding this comment.
Dead code after
exec_tests call
exec_tests unconditionally replaces the current process via os.execv, so return 0 on the line that follows is never executed. If exec_tests is ever refactored to not exec (e.g., for testability), the caller would silently return success regardless of the test outcome. The function signature and docstring both declare the no-return contract, so the unreachable line should be removed to avoid misleading future readers.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
| """Tests for the multi-GPU CI selection utility.""" | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| import importlib.util |
There was a problem hiding this comment.
Module-level
assert gives an opaque failure on script-not-found
If SCRIPT doesn't exist or the spec loader is None, the bare assert raises a bare AssertionError with no diagnostic text. When Python is run with -O or -OO, assert statements are compiled away entirely, turning a missing-script condition into an AttributeError on the None loader later. Using a conditional raise RuntimeError(...) guard would produce clear, optimisation-safe error messages at import time.
PhysicsNeMo Pull Request
Description
Checklist
Dependencies
Review Process
All PRs are reviewed by the PhysicsNeMo team before merging.
Depending on which files are changed, GitHub may automatically assign a maintainer for review.
We are also testing AI-based code review tools (e.g., Greptile), which may add automated comments with a confidence score.
This score reflects the AI’s assessment of merge readiness and is not a qualitative judgment of your work, nor is
it an indication that the PR will be accepted / rejected.
AI-generated feedback should be reviewed critically for usefulness.
You are not required to respond to every AI comment, but they are intended to help both authors and reviewers.
Please react to Greptile comments with 👍 or 👎 to provide feedback on their accuracy.