Rework ParseBytes to return uint64 instead of interface#148
Conversation
5e5afb0 to
0c9078b
Compare
|
hm, wouldn't it make sense to remove the types |
|
Yeah I think you're right. We can simplify that. |
|
@RincewindsHat I squashed some things together while keeping the same functionality |
RincewindsHat
left a comment
There was a problem hiding this comment.
Looks good now, minmal and pretty clear.
Should we keep the Bytes = uint64 alias to make it more obvious that you get that from the one function and put it into the other?
Or is it plainly obvious that the uint64 is the number of bytes?
|
I think uint64 and clear documentation is fine. |
205f22e to
dfecb1f
Compare
Also replaces byte types with functions
dfecb1f to
7efe235
Compare
|
@RincewindsHat squashed the commits, added some examples to the docs. |
Fixes #147