fix: remove dead *_MOK assignments in file_per_process I/O branches#1598
Draft
SVS87 wants to merge 1 commit into
Draft
fix: remove dead *_MOK assignments in file_per_process I/O branches#1598SVS87 wants to merge 1 commit into
SVS87 wants to merge 1 commit into
Conversation
In the sequential file_per_process paths (MPI_COMM_SELF), the *_MOK offset variables are computed but never used — no MPI_FILE_SET_VIEW or disp displacement is present in these branches. Also removes the copy-paste typo where n_MOK and p_MOK were both derived from m_glb_read instead of n_glb_read/p_glb_read in m_start_up.fpp. Fixes MFlowCode#1490
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1598 +/- ##
==========================================
- Coverage 60.94% 60.94% -0.01%
==========================================
Files 82 82
Lines 19922 19921 -1
Branches 2924 2924
==========================================
- Hits 12141 12140 -1
Misses 5805 5805
Partials 1976 1976 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the sequential file_per_process paths (MPI_COMM_SELF), the *_MOK offset variables are computed but never used — no MPI_FILE_SET_VIEW or disp displacement is present in these branches.
Also removes the copy-paste typo where n_MOK and p_MOK were both derived from m_glb_read instead of n_glb_read/p_glb_read in m_start_up.fpp.
Closes #1490
Type of change (delete unused ones)
Testing
Ran ./mfc.sh format and lint locally. No functional behavior changes — removing dead assignments to never-read variables in sequential MPI_COMM_SELF branches. The collective SET_VIEW path that actually uses *_MOK is untouched.
Checklist
Check these like this
[x]to indicate which of the below applies.See the developer guide for full coding standards.
GPU changes (expand if you modified
src/simulation/)Dead code removal only, no GPU behavior changes
AI code reviews
Reviews are not retriggered automatically. To request a review, comment on the PR:
@claude full review— Claude full review (also triggers on PR open/reopen/ready)claude-full-review— Claude full review via label