Skip to content

feat(lpdb): implement typechecks for LPDB Models#7708

Open
ElectricalBoy wants to merge 13 commits into
mainfrom
lpdb_typecheck
Open

feat(lpdb): implement typechecks for LPDB Models#7708
ElectricalBoy wants to merge 13 commits into
mainfrom
lpdb_typecheck

Conversation

@ElectricalBoy

@ElectricalBoy ElectricalBoy commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Summary

-- TODO: Verify types (at least when running tests)

This PR implements typechecking for data stored through LPDB models.
Typechecking is disabled by default (for performance reasons) and can be enabled with force_type_check feature flag (the same flag used in DisplayUtil.assertPropTypes).

How did you test this change?

https://github.com/Liquipedia/Lua-Modules/actions/runs/28428250217/job/84236424691

@ElectricalBoy ElectricalBoy marked this pull request as ready for review June 30, 2026 07:39
@ElectricalBoy ElectricalBoy requested review from a team as code owners June 30, 2026 07:39
@ElectricalBoy ElectricalBoy changed the title feat(lpdb): enable typechecks when storing from LPDB Model feat(lpdb): implement typechecks for LPDB Models Jun 30, 2026

@hjpalpha hjpalpha left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable

Comment thread lua/spec/match2_spec.lua
Comment on lines 5 to 7
local Json = require('Module:Json')

before_each(function ()

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants