feat(PrizePool): redesign table via Table2 with collapse rework#7688
Open
Eetwalt wants to merge 46 commits into
Open
feat(PrizePool): redesign table via Table2 with collapse rework#7688Eetwalt wants to merge 46 commits into
Eetwalt wants to merge 46 commits into
Conversation
Collaborator
Author
This can be in a separate PR imo |
Collaborator
there already is #7687 |
Collaborator
there's no way that there won't be a merge conflict |
mbergen
reviewed
Jun 29, 2026
Collaborator
Author
Looking at https://liquipedia.net/dota2/index.php?title=BLAST/SLAM/7 with old and new prizepool, there seems to be not much difference
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Widget/TabletoWidget/Table2(header/body/footer sections, declarativerowspan/colspan)general-collapsibletoggle rendered in the footer, replacing the per-rowapplyToggleExpandmachinery; child classes now only supply open/close label textArray.groupAdjacentBy/Table.deepEquals, extracted into_opponentPrizeCells1,1-2) instead of ordinals, with colored gold/silver/bronze badges and pale row tints for top-3.prizepool-table-wrapperrowspan/colspanfrom Table2Cell/CellHeadereven without column definitionsHow did you test this change?
dev + devtools