Modified code to be able to execute SSRS xml report files.#1756
Merged
Conversation
Contributor
|
@Ohsudev did you create this branch in the hopes of fixing the TeamCity failure? I just pushed a fix into my copy of the feature branch. |
…'s recent code to fix issues Github errors.
Collaborator
Author
|
Josh. I have added your program fix to my PR. Can you please review this PR for me. Thanks. |
labkey-jeckels
approved these changes
Jun 11, 2026
| @@ -174,7 +175,8 @@ public static class GetSessionIdAction extends MutatingApiAction<Object> | |||
| @Override | |||
| public Object execute(Object o, BindException errors) | |||
Contributor
There was a problem hiding this comment.
Consider if you want to include the explanatory comment in my branch.
| public Object execute(Object o, BindException errors) | ||
| { | ||
| return Map.of("SessionId", getViewContext().getRequest().getSession(true).getId()); | ||
| // return Map.of("SessionId", getViewContext().getRequest().getSession(true).getId()); |
Contributor
There was a problem hiding this comment.
Is there a need to keep this commented out line?
Comment on lines
+2
to
+16
| * Copyright (c) 2026 LabKey Corporation | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.labkey.test.tests.onprc_ehr; |
Contributor
There was a problem hiding this comment.
Nonstandard indentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created a new PR from Josh's code to fix an issue with the SSRS xml connection string