fix bash 3 incompatibilities to allow tests to run on macOS#79
Merged
Conversation
Three bash 4+ constructs broke test runs on macOS (bash 3.2):
- `${var^^}` (uppercase expansion) in _skip_step and test_internals.sh
replaced with `tr '[:lower:]' '[:upper:]'`
- `free -m` (Linux-only memory command) in step_default_envs
now falls back to 1024M when free is not available
- `${var::-7}` (negative-offset substring) replaced with
`${var%.tar.gz}` and `${var%-embedded.tar.gz}` throughout
CI (Ubuntu, bash 5) is unaffected. These changes make the test suite
runnable locally on macOS without requiring homebrew bash.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
labkey-jony
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
${var^^}(bash 4+ uppercase expansion) in_skip_stepwithtr '[:lower:]' '[:upper:]'— affectsinstall-labkey.bash,install-wcp.bash, andtest/test_internals.sh1024Minstep_default_envswhenfree(Linux-only) is not available${var::-7}/${var::-16}(bash 4+ negative substring) with${var%.tar.gz}/${var%-embedded.tar.gz}Test plan
./test/runner.shpasses locally on macOS🤖 Generated with Claude Code