25.7 fb container scoping#1022
Open
labkey-klum wants to merge 11 commits into
Open
Conversation
This was referenced Jun 11, 2026
| if (!selections.isEmpty()) | ||
| { | ||
| // GitHub Kanban #1892: Verify each selected run belongs to the current container before queuing | ||
| for (String selection : selections) |
Contributor
There was a problem hiding this comment.
nit: We should be cautious of taking data region selections and translating them into single objects / non-aggregate queries. Perhaps the scales here do not warrant change.
| ActionURL url = getViewContext().getActionURL(); | ||
| // Read scriptId from the action URL (falling back to the request parameter) so it resolves under both | ||
| // real browser requests and in-JVM mock dispatch, mirroring how runId/compId below are read from the URL. | ||
| String scriptIdStr = url.getParameter("scriptId"); |
Contributor
There was a problem hiding this comment.
This should not be necessary given the change made in the platform PR to the mocking to support getParameter().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Add permission checks for objects referenced by rowID.
Related Pull Requests