revert(ai-gateway): remove temporary stream diagnostics#3976
Open
marius-kilocode wants to merge 1 commit into
Open
revert(ai-gateway): remove temporary stream diagnostics#3976marius-kilocode wants to merge 1 commit into
marius-kilocode wants to merge 1 commit into
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryClean removal-only revert of #3946 that deletes the temporary stream lifecycle instrumentation ( Files Reviewed (3 files)
Reviewed by claude-sonnet-4.6 · 233,995 tokens Review guidance: REVIEW.md from base branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#3946 added temporary lifecycle instrumentation for direct-provider SSE responses while investigating response loss. The instrumentation adds stream parsing and hashing, sampled lifecycle records, and an
x-kilo-attempt-idresponse header to the normal request path.Revert #3946 now that the diagnostic change is no longer needed. This removes both stream observers and their scanner tests, removes lifecycle classification and sampled logging, removes the diagnostic response header, and restores the gateway route's prior response fan-out and return behavior.
Verification
N/A
Visual Changes
N/A
Reviewer Notes
This is a removal-only revert of #3946 and does not introduce a replacement stream-lifetime behavior.