fix(code-reviews): expire stale reviews#3973
Open
alex-alecu wants to merge 1 commit into
Open
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryThe PR correctly introduces a stale-review expiry step in the dispatch cron — the CTE-based cancellation query is safe, the fresh-retry guard is correct, type definitions are consistently updated across all packages, and the race condition with in-flight workers is already handled by the existing terminal-state guard in the status callback route. Files Reviewed (7 files)
Reviewed by claude-4.6-sonnet-20260217 · 1,122,494 tokens Review guidance: REVIEW.md from base branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
N/A (no manual verification performed).
Visual Changes
N/A
Reviewer Notes
The cron marks rows as cancelled in the database only. It does not stop an already running worker or close an external pull request check.