[BUG] [CRITICAL] TcoDrivesBeckhoff.TcoMultiAxis Loading position set in automat#62
Merged
peterbarancek merged 2 commits intoJun 16, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent operators from loading/saving/editing position sets from the WPF service views while the axis is not in service/manual mode (to mitigate the “load position set in automat” safety issue described in #50).
Changes:
- Disable the Positions section in
TcoSingleAxisServiceViewunlessComponent._inServiceMode.Cyclicis true. - Disable the Positions section in
TcoMultiAxisServiceViewunlessComponent._inServiceMode.Cyclicis true.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/TcoDrivesBeckhoff/src/TcoDrivesBeckhoff.Wpf/TcoSingleAxis/Service/TcoSingleAxisServiceView.xaml |
Adds _inServiceMode-based gating to disable the Positions UI when not in service/manual mode. |
src/TcoDrivesBeckhoff/src/TcoDrivesBeckhoff.Wpf/TcoMultiAxis/Service/TcoMultiAxisServiceView.xaml |
Adds _inServiceMode-based gating to disable the Positions UI when not in service/manual mode. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| </StackPanel> | ||
| </GroupBox> | ||
| <GroupBox Padding="10" Header="{x:Static p:strings.Positions}" HorizontalAlignment="Stretch" Visibility="{Binding Component._config.HidePositionTable.Cyclic, Converter={vortex:BooleanToVisibilityConverter},ConverterParameter=true}"> | ||
| <GroupBox Padding="10" IsEnabled="{Binding Component._inServiceMode.Cyclic}" Header="{x:Static p:strings.Positions}" HorizontalAlignment="Stretch" Visibility="{Binding Component._config.HidePositionTable.Cyclic, Converter={vortex:BooleanToVisibilityConverter},ConverterParameter=true}"> |
| </StackPanel> | ||
| </GroupBox> | ||
| <GroupBox Padding="10" Header="{x:Static p:strings.Positions}" HorizontalAlignment="Stretch" Visibility="{Binding Component._config.HidePositionTable.Cyclic, Converter={vortex:BooleanToVisibilityConverter},ConverterParameter=true}"> | ||
| <GroupBox Padding="10" IsEnabled="{Binding Component._inServiceMode.Cyclic}" Header="{x:Static p:strings.Positions}" HorizontalAlignment="Stretch" Visibility="{Binding Component._config.HidePositionTable.Cyclic, Converter={vortex:BooleanToVisibilityConverter},ConverterParameter=true}"> |
|
|
||
| </GroupBox> | ||
| <GroupBox Padding="10" Header="{x:Static p:strings.Positions}" HorizontalAlignment="Stretch" | ||
| <GroupBox Padding="10" IsEnabled="{Binding Component._inServiceMode.Cyclic}" Header="{x:Static p:strings.Positions}" HorizontalAlignment="Stretch" |
|
|
||
| </GroupBox> | ||
| <GroupBox Padding="10" Header="{x:Static p:strings.Positions}" HorizontalAlignment="Stretch" | ||
| <GroupBox Padding="10" IsEnabled="{Binding Component._inServiceMode.Cyclic}" Header="{x:Static p:strings.Positions}" HorizontalAlignment="Stretch" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #50