[BUG] TcoComprehensiveResult missing translation tags#61
Merged
peterbarancek merged 2 commits intoJun 15, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes missing translation metadata for TcoComprehensiveResult so its fields can be localized in tooling/UI (closes #49).
Changes:
- Added TwinCAT
{attribute addProperty Name "<#...#>"}translation tags toTcoComprehensiveResultfields. - Added corresponding
Result/Failures/ErrorCodesentries to WPFstrings*.resxresources. - Added missing connector localization keys for the new tags in
Localizations.resx.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/TcoInspectors/src/XAE/XAE/TcoInspectors/POUs/TcoInspector/TcoComprehensiveResult.TcDUT |
Adds translation-tagged property names for Result, Failures, ErrorCodes. |
src/TcoInspectors/src/Wpf/TcOpen.Inxton.TcoInspectors.Wpf/Properties/strings.resx |
Adds neutral-culture WPF strings for the new labels. |
src/TcoInspectors/src/Wpf/TcOpen.Inxton.TcoInspectors.Wpf/Properties/strings.sk-SK.resx |
Adds Slovak translations for the new labels. |
src/TcoInspectors/src/Wpf/TcOpen.Inxton.TcoInspectors.Wpf/Properties/strings.es-MX.resx |
Adds es-MX translations for the new labels. |
src/TcoInspectors/src/Wpf/TcOpen.Inxton.TcoInspectors.Wpf/Properties/strings.es-ES.resx |
Adds es-ES translations for the new labels. |
src/TcoInspectors/src/Wpf/TcOpen.Inxton.TcoInspectors.Wpf/Properties/strings.de-DE.resx |
Adds German translations for the new labels. |
src/TcoInspectors/src/Wpf/TcOpen.Inxton.TcoInspectors.Wpf/Properties/strings.cs-CZ.resx |
Adds Czech translations for the new labels. |
src/TcoInspectors/src/TcoInspectorsConnector/Properties/Localizations.resx |
Adds connector localization keys for the new tags (and reorders/adjusts existing entries). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+126
to
+128
| <data name="___ErrorCodes__" xml:space="preserve"> | ||
| <value>ErrorCodes</value> | ||
| </data> |
Comment on lines
+120
to
+128
| <data name="___Result__" xml:space="preserve"> | ||
| <value>Result</value> | ||
| </data> | ||
| <data name="___Failures__" xml:space="preserve"> | ||
| <value>Failures</value> | ||
| </data> | ||
| <data name="___ErrorCodes__" xml:space="preserve"> | ||
| <value>ErrorCodes</value> | ||
| </data> |
Comment on lines
+153
to
+161
| <data name="Result" xml:space="preserve"> | ||
| <value>Result</value> | ||
| </data> | ||
| <data name="Failures" xml:space="preserve"> | ||
| <value>Failures</value> | ||
| </data> | ||
| <data name="ErrorCodes" xml:space="preserve"> | ||
| <value>Error codes</value> | ||
| </data> |
Comment on lines
+120
to
+128
| <data name="___Result__" xml:space="preserve"> | ||
| <value>Result</value> | ||
| </data> | ||
| <data name="___Failures__" xml:space="preserve"> | ||
| <value>Failures</value> | ||
| </data> | ||
| <data name="___ErrorCodes__" xml:space="preserve"> | ||
| <value>ErrorCodes</value> | ||
| </data> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #49