feat: add tags for snapshot#23
Merged
Merged
Conversation
Signed-off-by: kerthcet <kerthcet@gmail.com>
InftyAI-Agent
added
needs-triage
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a Git-style tag reference mechanism for snapshots by persisting tag→snapshot mappings as files under refs/tags/, enabling O(1) lookup/filtering by tag and cleaning up tag refs on snapshot deletion.
Changes:
- Add
tags_dirstorage and write tag ref files (refs/tags/<tag>) during snapshot creation. - Update snapshot listing and tag lookup to use tag refs (and change
find_by_tagto return a single snapshot). - Extend the snapshot design proposal doc to document the new tag ref layout and semantics.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| sandd/src/snapshot/manager.rs | Implements tag ref directory initialization, tag ref creation/removal/lookup, and updates list/find/delete behavior to use tag refs. |
| docs/proposals/SNAPSHOTS.md | Documents the new refs/tags/ layout and updates API/examples to reflect tag ref lookup behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: kerthcet <kerthcet@gmail.com>
Signed-off-by: kerthcet <kerthcet@gmail.com>
Member
Author
|
/lgtm |
Member
Author
|
/kind feature |
InftyAI-Agent
added
the
lgtm
InftyAI-Agent
added
feature
InftyAI-Agent
approved these changes
Jun 29, 2026
InftyAI-Agent
left a comment
InftyAI-Agent
left a comment
Member
There was a problem hiding this comment.
Approved: PR has both lgtm and approved labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Which issue(s) this PR fixes
part of #6
Special notes for your reviewer
Does this PR introduce a user-facing change?