fix: datetime verification evaluation about UTC in issuance and expiration#36
Open
peppelinux wants to merge 1 commit into
Open
fix: datetime verification evaluation about UTC in issuance and expiration#36peppelinux wants to merge 1 commit into
peppelinux wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the handling of date-only validity periods in the
MsoIssuerclass by introducing a new date parsing method and updating the signing logic to ensure correct interpretation of expiry dates. It also adds a new test to verify that validity intervals are correctly set when issuance and expiry are on the same day.Date parsing and validity handling improvements:
parse_datetoMsoIssuerinissuer.pyto parse date-only strings and, when appropriate, set the time to the end of the day for expiry dates.signmethod inMsoIssuerto use the newparse_datemethod for both issuance and expiry dates, ensuring expiry is interpreted as the end of the day.Testing enhancements:
test_mso_issuer_validity_same_dayto verify that when issuance and expiry dates are the same, the validity interval includes the entire day and thevalidUntiltime is set to 23:59:59.datetimeandcbor2in the test file.