Draft: T&A Export/Import Refactoring#11673
Open
lukas-heinrich wants to merge 43 commits into
Open
Conversation
This commit was created from various other commits across multiple branches. These were combined to simplify the merge process and to separate the foundation from the implementations in the Questions and Test components.
…etach calls Stream::detach() nullifies uri and _mode, which made ReattachableStream unable to reopen the resource afterwards. Override detach() to store both values before the parent clears them, so assertStreamAttached() can reliably reattach.
…r better traceability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi everyone,
this PR concerns the refactoring of export/import in the Test and TestQuestionPool components.
Objective
This refactoring reintegrates the test export into the intended export process of ILIAS. In detail, the PR pursues the following objectives:
Core idea
The export process is divided into two clearly separated responsibilities:
This separation ensures that the export can be implemented independently of the output format, so that not every exportoption needs to build its own process.
The complete concept, including more detailed explanations, is attached here:
Konzeption_ Test Export.pdf
Note: This PR is currently still in an internal review process and is not yet final. Bug fixes and cleanup work will be added incrementally. We nevertheless welcome any comments and feedback.