feat(Platform Notifications): add new service to the project#325
Merged
Conversation
|
|
Member
Author
|
Do not merge yet |
pyrooka
changed the title
pyrooka
changed the title
pyrooka
requested changes
May 6, 2026
pyrooka
left a comment
pyrooka
left a comment
Member
There was a problem hiding this comment.
Changes are looking good, but I'd like to ask you to
- Format the code with
make lint-fix - Provide evidence of a clean examples test run.
Member
Author
|
example tests: |
Signed-off-by: Ákos Sztremi <Akos.Sztremi@ibm.com>
Signed-off-by: Ákos Sztremi <Akos.Sztremi@ibm.com>
Signed-off-by: Ákos Sztremi <Akos.Sztremi@ibm.com>
Signed-off-by: Ákos Sztremi <Akos.Sztremi@ibm.com>
Signed-off-by: Ákos Sztremi <Akos.Sztremi@ibm.com>
Signed-off-by: Ákos Sztremi <Akos.Sztremi@ibm.com>
Signed-off-by: Ákos Sztremi <Akos.Sztremi@ibm.com>
Member
Author
|
test results for lates commit: Unit tests
Integration tests
Exaple tests
|
pyrooka
approved these changes
Jun 16, 2026
pyrooka
left a comment
pyrooka
left a comment
Member
There was a problem hiding this comment.
I left a small comment that would be nice to address before merging, but I approve this PR since it looks good overall and this way we can avoid the re-review.
Comment on lines
+28
to
+32
| # The following configuration properties are assumed to be defined: | ||
| # PLATFORM_NOTIFICATIONS_URL=<service base url> | ||
| # PLATFORM_NOTIFICATIONS_AUTH_TYPE=iam | ||
| # PLATFORM_NOTIFICATIONS_APIKEY=<IAM apikey> | ||
| # PLATFORM_NOTIFICATIONS_AUTH_URL=<IAM token service base URL - omit this if using the production environment> |
Member
There was a problem hiding this comment.
Could you update this list to contain all the necessary config properties?
Signed-off-by: Ákos Sztremi <Akos.Sztremi@ibm.com>
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Jun 25, 2026
# [0.76.0](v0.75.2...v0.76.0) (2026-06-25) ### Features * **Platform Notifications:** add new service to the project ([#325](#325)) ([c976caa](c976caa))
|
🎉 This PR is included in version 0.76.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
PR Checklist
Please make sure that your PR fulfills the following requirements:
Current vs new behavior
Does this PR introduce a breaking change?
Other information
Integration test results:
Unit test results