Harden edgezero #269 runtime config-store load (HTTP layer)#783
Draft
prk-Jr wants to merge 16 commits into
Draft
Harden edgezero #269 runtime config-store load (HTTP layer)#783prk-Jr wants to merge 16 commits into
prk-Jr wants to merge 16 commits into
Conversation
This reverts commit a09cadc.
The runtime reconstructs Settings from the app_config config store at request time, but the Viceroy integration fixture never declared that store, so every settings-dependent route returned 503 (EC batch sync) or skipped injection (HTML), and the browser harness never became ready. Seed app_config from a single source — a new integration trusted-server.toml fixture (example config plus the origin, proxy-secret, EC passphrase, EC partner, and certificate-check overrides the build previously passed as env vars). A shared render_seeded_viceroy_config helper builds the config-store payload via build_config_payload, so the Rust test harness and the new seed-viceroy-config binary used by the browser runner stay in lockstep. - fastly.rs renders a seeded Viceroy config per spawn into a temp file removed on drop - browser runner script and CI job seed via the binary and point VICEROY_CONFIG_PATH at it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stackpop/edgezero#269. Stacked onfeature/ts-cli-next(which carries the As a buyer, I want the first bid request to include IAB cohorts, signals, and synthetic ID #269 repin,Bodyfixes, the Fastly adapter migration, and config-store-backedSettingsload). Draft — base is unmerged; retarget tomainoncets-cli-nextlands.TrustedServerError::ConfigStoreUnavailable→ 503, while a reconstruct/verify failure (settings_from_config_entries: hash mismatch / unparseable) stays 500. One new error variant; no platform-layer change.run \ts config push``) goes to server logs (error chain); the public 503 body stays generic by design.Base note: diff is against
feature/ts-cli-next, so it shows only this branch's work. Againstmainit would include all ofts-cli-next.Changes
crates/trusted-server-core/src/error.rsConfigStoreUnavailable { store_name, message }variant → 503 (+ exhaustiveness guard, unit test)crates/trusted-server-core/src/settings_data.rsread_config_entryread failures →ConfigStoreUnavailable; tests (unseeded→503, malformed-hash→500, missing-listed-key→503, hint-in-chain)crates/trusted-server-adapter-fastly/src/error.rsConfigStoreUnavailablerenders 503 to client viato_error_responsecrates/integration-tests/Cargo.lockCloses
n/a — issue linking skipped by request.
Test plan
cargo test --workspace(core 1376 / adapter 39, 0 fail)cargo clippy --workspace --all-targets --all-features -- -D warningscargo fmt --all -- --checkcargo build -p trusted-server-adapter-fastly --release --target wasm32-wasip1Checklist
log, colocated tests)unwrap()in production code