Skip to content

Fix login form: use label elements instead of th for accessibility #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VDK wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix login form: use label elements instead of th for accessibility #53

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions resources/com/google/gerrit/httpd/auth/ldap/LoginForm.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,14 @@ <h1>Sign In to Gerrit Code Review at <span id="hostName">example.com</span></h1>
<form method="POST" action="#" id="login_form" autocomplete="off" onsubmit="return shouldSubmit()">
<table style="border: 0;">
<tr>
<th>Username</th>
<td><label for="f_user">Username</label></td>
<td><input name="username" id="f_user"
type="text"
size="25"
tabindex="1" /></td>
</tr>
<tr>
<th>Password</th>
<td><label for="f_pass">Password</label></td>
<td><input name="password" id="f_pass"
type="password"
size="25"
Expand Down