fix(specialpower): Prevent null pointer dereference in Thing::setPosition#526
Open
seer-by-sentry[bot] wants to merge 1 commit into
Open
fix(specialpower): Prevent null pointer dereference in Thing::setPosition#526seer-by-sentry[bot] wants to merge 1 commit into
seer-by-sentry[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue CLIENT-520, a fatal crash caused by a null pointer dereference in
Thing::setPosition.Root Cause:
SpecialPowerModule::doSpecialPowerUsingWaypointsintentionally callstriggerSpecialPower(nullptr)for special powers that do not create view objects. Thisnullptris then forwarded toSpecialPowerModule::createViewObject. ThecreateViewObjectfunction, however, did not have an early null check for thelocationparameter. Consequently, after creating aviewObject, it would attempt to callviewObject->setPosition(location)with a nulllocation, leading to anEXCEPTION_ACCESS_VIOLATION_READ.Solution:
Added an
if (location == nullptr) return;guard at the very beginning ofSpecialPowerModule::createViewObjectin bothGenerals/andGeneralsMD/code paths. This ensures that if a special power does not require a view object (and thus passes a null location), the function exits gracefully without attempting to set the position of a non-existent object at a null location.Fixes CLIENT-520