Skip to content

fix(stats): Award win to winner when opponent disconnects and avoid resetting win streak #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
x64-dev merged 2 commits into from
Jun 21, 2026
Merged

fix(stats): Award win to winner when opponent disconnects and avoid resetting win streak #364

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6dede8
Award win to remaining and avoid resetting win streak when opponent d…
MrS-ibra Feb 28, 2026
d68c08f
Merge branch 'main' into disconnect-win-award
MrS-ibra Jun 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 18 additions & 16 deletions GeneralsMD/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/ScoreScreen.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1922,27 +1922,29 @@ winName.format("ScoreScreen.wnd:StaticTextScore%d", pos);

if (gameEndedInDisconnect)
{
// we pinged on the last frame someone was there - i.e. game ended in a disconnect.
// check if we were to blame.
if (TheNetwork->getPingsReceived() < max(1, TheNetwork->getPingsSent()/2)) /// @todo: what's a good percent of pings to have gotten?
#if defined(GENERALS_ONLINE)
// TODO_NGMP we need to detect this on service.
// Use victory conditions to avoid penolizing the innocent player for now.
if (!TheVictoryConditions->isLocalAlliedVictory())
{
DEBUG_LOG(("We were to blame. Leaving gameEndedInDisconnect = true"));
// we pinged on the last frame someone was there - i.e. game ended in a disconnect.
// check if we were to blame.
if (TheNetwork->getPingsReceived() < max(1, TheNetwork->getPingsSent() / 2)) /// @todo: what's a good percent of pings to have gotten?
{
DEBUG_LOG(("We were to blame. Leaving gameEndedInDisconnect = true\n"));
}
else
{
DEBUG_LOG(("We were not to blame. Changing gameEndedInDisconnect = false\n"));
gameEndedInDisconnect = FALSE;
}
DEBUG_LOG(("[DISC] we disconnected, gameEndedInDisconnect = true\n"));
}
else
{
DEBUG_LOG(("gameEndedInDisconnect, and we didn't ping on last frame. What's up with that?\n"));
DEBUG_LOG(("[DISC] opponent disconnected, gameEndedInDisconnect = false\n"));
gameEndedInDisconnect = FALSE;
}
#else
if (TheNetwork->getPingsRecieved() < max(1, TheNetwork->getPingsSent() / 2))
{
DEBUG_LOG(("We were to blame. Leaving gameEndedInDisconnect = true\n"));
}
else
{
DEBUG_LOG(("We were not to blame. Changing gameEndedInDisconnect = false\n"));
gameEndedInDisconnect = FALSE;
}
#endif
}

ScoreKeeper* s = player->getScoreKeeper();
Expand Down
Loading