fix installer lib not loading in ide#643
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the WiX library project so it stays loadable in Visual Studio by avoiding references to generated authoring under intermediate output paths and by setting sensible default MSBuild properties.
Changes:
- Added default
Configuration/Platformvalues to the WiX library project to stabilize design-time evaluation. - Moved the generated
UciDist.wxsfragment output under the project directory (Generated\) and updated build/compile inputs accordingly. - Added
.gitignoreentries for the new generated output folder and an additional UCI working directory name.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| IntelPresentMon/PMInstallerLib/PMInstallerLib.wixproj | Generates/consumes the harvested UCI fragment from a stable project-relative path to improve IDE load behavior. |
| IntelPresentMon/ControlLib/uci/.gitignore | Ignores an additional UCI directory (external-off/). |
| .gitignore | Ignores PMInstallerLib/Generated/ to prevent committing harvested WiX authoring. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix issue where wix library project gets/stays unloaded in IDE view