chore(platforms/lpc): track main of platform-nxplpc-arduino#16
Conversation
…er configs
ESP32-family and ESP8266 starter configs all linked at ~600 KB
Blink-class binaries because the default Arduino-ESP32 build carries:
- build_type = debug + -Og (no optimization)
- CORE_DEBUG_LEVEL=5 + ESP_LOG_VERBOSE (every log string compiled in)
- full libstdc++ exception machinery (no -fno-exceptions / -fno-rtti)
- no per-function/data sections + no -Wl,--gc-sections, so the linker
drops nothing it doesn't have to
Adds a heavily commented [build_type=release / build_flags / build_unflags]
block to each ESP env. Result on FastLED's own esp32dev CI:
Blink: 631100 B -> 408136 B (-223 KB / -35%)
The block is fully commented for new users: 'comment out (or set
build_type = debug) when you need verbose logs / exception decoding
while developing.' Each file points to the FastLED PR that did the
investigation (FastLED/FastLED#3268).
Files updated (all 11):
platformio.esp32c2.ini
platformio.esp32c3.ini
platformio.esp32c5.ini (preserves existing PARLIO ISR flags)
platformio.esp32c6.ini (preserves existing PARLIO ISR flags)
platformio.esp32dev.ini
platformio.esp32h2.ini (preserves existing PARLIO ISR flags)
platformio.esp32p4.ini (preserves existing PARLIO ISR flags)
platformio.esp32s2.ini
platformio.esp32s3.ini (preserves existing exception_decoder filter)
platformio.esp8266.ini (NONOS SDK — no CORE_DEBUG_LEVEL macro)
platformio.seeed_xiao_esp32s3.ini
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Switch every LPC8xx env from the SHA-pinned platform URL to `zackees/platform-nxplpc-arduino.git#main`. The package is stable and its maintainer (also this repo's maintainer) prefers users automatically pick up upstream fixes rather than be stuck on a frozen commit. Trim the env header comments accordingly — drop the "pin to a known-good commit" / "do not point users at the upstream registry" framing that treated the package like a fragile workaround, since it isn't one. Keep the single neutral sentence noting it isn't in the upstream PlatformIO registry, which still explains why the URL uses git. Affected envs: - lpc845brk - lpc845 - lpcxpresso845max - lpc804 - lpcxpresso804 No board, framework, build_flags or lib_deps changes. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 51 minutes and 42 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (16)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Summary
Switch every LPC8xx env added in #14 from the SHA-pinned platform URL to
zackees/platform-nxplpc-arduino.git#main.Affects all five LPC envs (
lpc845brk,lpc845,lpcxpresso845max,lpc804,lpcxpresso804).Why
The package is stable and the maintainer wants PlatformIO-Starter users to pick up upstream fixes automatically rather than be stuck on the frozen
2ee527ae...SHA. The earlier env comments treated the package like a fragile workaround ("pin to a known-good commit", "NOT in the upstream registry — beware") — that framing was overcautious and is dropped here. A single neutral sentence noting the package isn't in the upstream registry stays, since it explains why the URL uses git.No board, framework, build_flags or lib_deps changes.
Test plan
pio run -c platforms/platformio.lpc845brk.inistill succeedspio run -c platforms/platformio.lpc845.inistill succeedspio run -c platforms/platformio.lpcxpresso845max.inistill succeedspio run -c platforms/platformio.lpc804.inistill succeedspio run -c platforms/platformio.lpcxpresso804.inistill succeeds🤖 Generated with Claude Code