fix(test): use php://stdout|stderr streams in smoke tests so they run under the Playground SAPI#2824
Open
chubes4 wants to merge 1 commit into
Open
fix(test): use php://stdout|stderr streams in smoke tests so they run under the Playground SAPI#2824chubes4 wants to merge 1 commit into
chubes4 wants to merge 1 commit into
Conversation
… under the Playground SAPI The STDOUT/STDERR PHP constants only exist under the CLI SAPI. The host smoke harness runs these tests under the WP Codebox Playground web SAPI where they are undefined, causing any reaching test to throw 'Undefined constant STDOUT'. Replace every `fwrite( STDOUT, ... )` / `fwrite( STDERR, ... )` call in the smoke suite with the equivalent `fopen( 'php://stdout'|'php://stderr', 'w' )` stream target. Message arguments and formatting are unchanged; only the stream target moves. This matches the form already in use by tests/conversation-compaction-policy-resolver-smoke.php on main. Mechanical sweep: 47 files, 75 call sites. Verified via `grep -rE "fwrite\(\s*STD(OUT|ERR)" tests/` returning no matches and php -l clean on every changed file. Closes #2823
Contributor
Homeboy Results —
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2823.
The
STDOUT/STDERRPHP constants only exist under the CLI SAPI. The host smoke harness runs these tests under the WP Codebox Playground web SAPI, where they are undefined, so any test reaching such a write throwsFatal error: Undefined constant "STDOUT"(orSTDERR).This is a purely mechanical sweep: replace every
fwrite( STDOUT, ... )/fwrite( STDERR, ... )call with the equivalentfopen( 'php://stdout'|'php://stderr', 'w' )stream target. Message arguments, formatting, indentation, and assertion logic are unchanged — only the stream target moves. This matches the form already in use bytests/conversation-compaction-policy-resolver-smoke.phponmain(the reference fix).Scope
STDERR+ 7STDOUT)fwrite( STDOUT|STDERR, ... )stream targets touched. No assertions, no behavior, no non-test files.Verification
grep -rE "fwrite\(\s*STD(OUT|ERR)" tests/→ no matches (clean).php -lclean on all 47 changed files.homeboy lint --changed-since origin/main→ passed, 0 findings.php tests/runtime-agent-bundle-reconcile-smoke.php→Runtime agent bundle reconcile smoke passed.php tests/content-addressed-data-packets-smoke.php→content-addressed-data-packets-smoke: okTransformation applied
Single quotes chosen to match the existing convention in
tests/(all pre-existingfopencalls and the reference fix onmainuse single quotes).Notes
internal.io_error/ "Setup command failed with exit code 100" / "No command results produced", that is infra, not this change.