Minecraft 26.2 and Velocity b604+ support#259
Draft
UserNugget wants to merge 2 commits into
Draft
Conversation
| private static final MethodHandle CONNECTED_PLAYER_CONSTRUCTOR; | ||
| private static final MethodHandle SPAWNED_FIELD; | ||
| private static final BiConsumer<ConnectedPlayer, TabList> TAB_LIST_SETTER; | ||
| private static final UUID SESSION_ID = UUID.randomUUID(); |
Contributor
There was a problem hiding this comment.
This should really use VelocityServer#getSessionId instead: PaperMC/Velocity@a758182
Member
There was a problem hiding this comment.
Pretty sure the player isn't in connectionsByUuid yet at that point, so it doesn't seem very logical.
And honestly, when you think about it, limbo is basically a server for a single player, so in theory you could just assign a random uuid to each login packet, which would match mojang's own logic, since a new uuid gets generated whenever the server drops to zero players
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Other Limbo* plugins should work fine, 26.2 has pretty small amount of protocol changes.