Linux support#8
Open
dimitriosGX wants to merge 2 commits into
Open
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 5 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="crates/edison-stdiod/src/platform/linux.rs">
<violation number="1" location="crates/edison-stdiod/src/platform/linux.rs:102">
P2: ExecStart uses an unquoted binary path, so paths with spaces break service startup. Quote the executable path in the unit template.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| \n\ | ||
| [Service]\n\ | ||
| Type=simple\n\ | ||
| ExecStart={bin} run\n\ |
There was a problem hiding this comment.
P2: ExecStart uses an unquoted binary path, so paths with spaces break service startup. Quote the executable path in the unit template.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At crates/edison-stdiod/src/platform/linux.rs, line 102:
<comment>ExecStart uses an unquoted binary path, so paths with spaces break service startup. Quote the executable path in the unit template.</comment>
<file context>
@@ -0,0 +1,274 @@
+ \n\
+ [Service]\n\
+ Type=simple\n\
+ ExecStart={bin} run\n\
+ Restart=on-failure\n\
+ RestartSec=5\n\
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Add Linux support for
edison-stdiodvia a systemd user service and ship staticmuslbinaries for x64 and arm64. This lets Linux users install the daemon per-user (no sudo) with reliable restarts and unified logs.New Features
~/.config/systemd/user/edison-stdiod.service, enables--now, usesRestart=on-failure,WantedBy=default.target, and avoids lingering.edison-stdiod rununder any init/PM.muslbinaries forx86_64andaarch64usingzig+cargo-zigbuild, smoke-tests x64, generatesSHA256SUMS-linux, uploads artifacts, and publishes on tags.scripts/build-linux.shto reproduce the static builds locally.Migration
edison-stdiod login --backend ... --api-key ...edison-stdiod install; Uninstall:edison-stdiod uninstall; Logs:edison-stdiod logs --followWritten for commit f2216ca. Summary will update on new commits.